Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test to demonstrate pair of "half" kernels sharing same public excess #3314

Merged
merged 3 commits into from
May 28, 2020

Conversation

antiochp
Copy link
Member

  • Added new build_two_half_kernels test
  • Cleanup test transaction building code (so we can pass explicit excess in)

The test code used to simply generate a random offset but we can now force it to use the appropriate offset to compensate for a specific excess value during tx building and kernel signing.

We intend to do something similar to this for NRD kernels once we have support for multi-party outputs. In real-world usage both participants would provide the necessary offset to adjust the final public excess back to a value shared across two transactions.

Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Still some files to review.

keychain/src/types.rs Show resolved Hide resolved
pool/src/pool.rs Show resolved Hide resolved
keychain/src/types.rs Outdated Show resolved Hide resolved
keychain/src/types.rs Show resolved Hide resolved
core/src/libtx/build.rs Show resolved Hide resolved
add test to demonstrate a pair of transaction halves sharing same kernel excess
Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@antiochp antiochp merged commit a8b8dc3 into mimblewimble:master May 28, 2020
@antiochp antiochp deleted the two_half_kernels branch May 28, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants