Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature)|Add support for SwiftPM #8

Merged
merged 5 commits into from
Nov 11, 2020
Merged

Conversation

johnhammerlund
Copy link
Contributor

Summary

This adds support for SwiftPM 5.3 while also maintaining existing support for Carthage / CocoaPods:

  • Source files have been restructured to follow Swift Package guidelines
  • Headers have been isolated in order to specify a publicHeadersPath. This includes _Private and _Protected headers, which don't really provide much benefit to begin with
  • NSBundle resolution attempts to access the generated SWIFTPM_MODULE_BUNDLE if it exists, which is necessary for projects that link the target via SwiftPM

Testing

Testing the compatibility of Carthage / CocoaPods / SwiftPM is unfortunately not self-contained. I've performed tests outside of this project to keep the scope maintainable.

The existing embedded demo application and tests should still run and pass.

Copy link

@bconway99 bconway99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and I love Swift Package Manager! 👍

@johnhammerlund johnhammerlund merged commit bb9362f into master Nov 11, 2020
@johnhammerlund johnhammerlund deleted the feature/swiftpm branch November 11, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants