Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enabled property from rule types #156

Closed
eleftherias opened this issue Sep 10, 2024 · 0 comments · Fixed by #160
Closed

Remove enabled property from rule types #156

eleftherias opened this issue Sep 10, 2024 · 0 comments · Fixed by #160
Assignees
@eleftherias

Comments

@eleftherias
Copy link
Contributor

Certain rule types, like secret_push_protection and secret_scanning have a property called enabled which can be set when defining a profile.
We should remove that property and assume enabled is implicitly true when the user selects the given rule.
@eleftherias eleftherias self-assigned this Sep 12, 2024
eleftherias added a commit to eleftherias/minder that referenced this issue Sep 17, 2024
@eleftherias
Add constant comparison operator to jq evaluation
be38dd9 
Ref mindersec/minder-rules-and-profiles#156
@eleftherias eleftherias mentioned this issue Sep 17, 2024
Merged
10 tasks
eleftherias added a commit to mindersec/minder that referenced this issue Sep 18, 2024
@eleftherias
Add constant comparison operator to jq evaluation (#4512)
3ee8d6d 
Ref mindersec/minder-rules-and-profiles#156
eleftherias added a commit that referenced this issue Sep 18, 2024
@eleftherias
Remove enabled property from ruletypes
eaaf2af 
Fix #156
@eleftherias eleftherias mentioned this issue Sep 18, 2024
Merged
eleftherias added a commit that referenced this issue Sep 19, 2024
@eleftherias
Remove enabled property from ruletypes
b783362 
Fix #156
eleftherias added a commit that referenced this issue Sep 19, 2024
@eleftherias
Remove enabled property from ruletypes (#160)
e182846 
Fix #156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove enabled property from ruletypes mindersec/minder-rules-and-profiles
1 participant
@eleftherias