Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusty rule does not require that an ecosystem is set #184

Closed
eleftherias opened this issue Oct 15, 2024 · 0 comments · Fixed by mindersec/minder#4773
Closed

Trusty rule does not require that an ecosystem is set #184

eleftherias opened this issue Oct 15, 2024 · 0 comments · Fixed by mindersec/minder#4773
Assignees
@eleftherias
Labels
P0 Fix Now: These are urgent issues that preempt other work in the current sprint

Comments

@eleftherias
Copy link
Contributor

When adding a Trusty rule to a profile from the UI, we do not require that an ecosystem is set. However, if we don't set an ecosystem then we get the following error when evaluating the rule

parsing policy configuration: failed to parse config: config failed validation: Key: 'config.EcosystemConfig' Error:Field validation for 'EcosystemConfig' failed on the 'required' tag

See UI screenshot:
Screenshot 2024-10-15 at 16 58 33
@eleftherias eleftherias added the P0 Fix Now: These are urgent issues that preempt other work in the current sprint label Oct 15, 2024
eleftherias added a commit to eleftherias/minder that referenced this issue Oct 17, 2024
@eleftherias
Change defaults for pull request rules
2543335 
Fix mindersec/minder-rules-and-profiles#184
@eleftherias eleftherias mentioned this issue Oct 17, 2024
Merged
10 tasks
@eleftherias eleftherias self-assigned this Oct 17, 2024
eleftherias added a commit to mindersec/minder that referenced this issue Oct 17, 2024
@eleftherias
Change defaults for pull request rules (#4773)
d3f88cf 
Fix mindersec/minder-rules-and-profiles#184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

Labels
P0 Fix Now: These are urgent issues that preempt other work in the current sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change defaults for pull request rules eleftherias/minder
1 participant
@eleftherias