Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ruletype that ensures that at least one workflow is triggered by pull_request #200

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Oct 24, 2024

This can be indicative of having a CI/CD pipeline

@jhrozek jhrozek requested a review from a team as a code owner October 24, 2024 09:22
@jhrozek
Copy link
Contributor Author

jhrozek commented Oct 24, 2024

@ethomson 👀

@ethomson
Copy link
Member

:excellent:

@eleftherias
Copy link
Contributor

@jhrozek Is there a story this should be tied to? (genuine question, not implying you should create a story)

@jhrozek
Copy link
Contributor Author

jhrozek commented Oct 24, 2024

@jhrozek Is there a story this should be tied to? (genuine question, not implying you should create a story)

There's a story of @ethomson pinging me on Slack asking me to do this :-P

No, really, this is related to PR #192 - having an extra ruletype would make the scorecard profile more complete. And since I was already working on PR #195 which is almost the same (just one is positive and one is negative and the event string is different), it was a straightforward thing to do.

eleftherias
eleftherias previously approved these changes Oct 24, 2024
@jhrozek
Copy link
Contributor Author

jhrozek commented Oct 24, 2024

btw we either need to fix the tests (PR #199 ) or I need to remove the test implementation for now from the PR

…y pull_request

This can be indicative of having a CI/CD pipeline
@jhrozek
Copy link
Contributor Author

jhrozek commented Oct 24, 2024

resubmitted without tests so we can merge faster - I'll submit the tests separately once we have the harness to run them merged.

@jhrozek
Copy link
Contributor Author

jhrozek commented Oct 24, 2024

(btw I made sure this rule works in Stacklok cloud prod and therefore that the JQ/rego dependencies have been deployed)

@jhrozek jhrozek merged commit 1f95748 into main Oct 24, 2024
2 checks passed
@jhrozek jhrozek deleted the some_pull_request_target branch October 24, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants