Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CLI to update provider config #3509

Closed
jhrozek opened this issue Jun 3, 2024 · 0 comments · Fixed by #3676
Closed

Add a CLI to update provider config #3509

jhrozek opened this issue Jun 3, 2024 · 0 comments · Fixed by #3676
Assignees
@blkt

Comments

@jhrozek
Copy link
Contributor

jhrozek commented Jun 3, 2024

After we merge PR #3468 we'll get the means to patch provider config via a call. But we also need to expose this functionality through the CLI so that the users could patch their configs.
@jhrozek jhrozek changed the title Add a CLI to set provider config Add a CLI to update provider config Jun 3, 2024
blkt added a commit that referenced this issue Jun 19, 2024
@blkt
Added minder provider update CLI command.
5992af8 
Update command allows changing configuration for provider on a
per-field basis. It operates on a read-modify-write fashion,
retrieving current configuration from the backend for modification.

Modification is done by reflection by walking over the struct's JSON
tags. Implementation is recursive, but the maximum depth is determined
by the deepest field in the configuration struct.

Argument parsing is trivial and assumes that arguments are either of
the form `field1.field2.field3` (for `--unset-attribute`) or
field1.field2.field3=value` (for `--set-attribute`). The right parser
for `value` is determined once the correct struct field is found.

It is not currently possible to modify `"github-app"` or `"github"`
fields.

Fixes #3509
blkt added a commit that referenced this issue Jun 19, 2024
@blkt
Added minder provider update CLI command.
2e282bf 
Update command allows changing configuration for provider on a
per-field basis. It operates on a read-modify-write fashion,
retrieving current configuration from the backend for modification.

Modification is done by reflection by walking over the struct's JSON
tags. Implementation is recursive, but the maximum depth is determined
by the deepest field in the configuration struct.

Argument parsing is trivial and assumes that arguments are either of
the form `field1.field2.field3` (for `--unset-attribute`) or
field1.field2.field3=value` (for `--set-attribute`). The right parser
for `value` is determined once the correct struct field is found.

It is not currently possible to modify `"github-app"` or `"github"`
fields.

Fixes #3509
@blkt blkt mentioned this issue Jun 19, 2024
Merged
10 tasks
blkt added a commit that referenced this issue Jun 19, 2024
@blkt
Added minder provider update CLI command.
a3229ac 
Update command allows changing configuration for provider on a
per-field basis. It operates on a read-modify-write fashion,
retrieving current configuration from the backend for modification.

Modification is done by reflection by walking over the struct's JSON
tags. Implementation is recursive, but the maximum depth is determined
by the deepest field in the configuration struct.

Argument parsing is trivial and assumes that arguments are either of
the form `field1.field2.field3` (for `--unset-attribute`) or
field1.field2.field3=value` (for `--set-attribute`). The right parser
for `value` is determined once the correct struct field is found.

It is not currently possible to modify `"github-app"` or `"github"`
fields.

Fixes #3509
blkt added a commit that referenced this issue Jun 20, 2024
@blkt
Added minder provider update CLI command.
7e374e9 
Update command allows changing configuration for provider on a
per-field basis. It operates on a read-modify-write fashion,
retrieving current configuration from the backend for modification.

Modification is done by reflection by walking over the struct's JSON
tags. Implementation is recursive, but the maximum depth is determined
by the deepest field in the configuration struct.

Argument parsing is trivial and assumes that arguments are either of
the form `field1.field2.field3` (for `--unset-attribute`) or
field1.field2.field3=value` (for `--set-attribute`). The right parser
for `value` is determined once the correct struct field is found.

It is not currently possible to modify `"github-app"` or `"github"`
fields.

Fixes #3509
blkt added a commit that referenced this issue Jun 20, 2024
@blkt
Added minder provider update CLI command. (#3676)
bef52d6 
Update command allows changing configuration for provider on a
per-field basis. It operates on a read-modify-write fashion,
retrieving current configuration from the backend for modification.

Modification is done by reflection by walking over the struct's JSON
tags. Implementation is recursive, but the maximum depth is determined
by the deepest field in the configuration struct.

Argument parsing is trivial and assumes that arguments are either of
the form `field1.field2.field3` (for `--unset-attribute`) or
field1.field2.field3=value` (for `--set-attribute`). The right parser
for `value` is determined once the correct struct field is found.

It is not currently possible to modify `"github-app"` or `"github"`
fields.

Fixes #3509
@jhrozek jhrozek mentioned this issue Jun 20, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blkt blkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added minder provider update CLI command. mindersec/minder
2 participants
@blkt @jhrozek