-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CLI to update provider config #3509
Comments
jhrozek
changed the title
Add a CLI to set provider config
Add a CLI to update provider config
Jun 3, 2024
blkt
added a commit
that referenced
this issue
Jun 19, 2024
Update command allows changing configuration for provider on a per-field basis. It operates on a read-modify-write fashion, retrieving current configuration from the backend for modification. Modification is done by reflection by walking over the struct's JSON tags. Implementation is recursive, but the maximum depth is determined by the deepest field in the configuration struct. Argument parsing is trivial and assumes that arguments are either of the form `field1.field2.field3` (for `--unset-attribute`) or field1.field2.field3=value` (for `--set-attribute`). The right parser for `value` is determined once the correct struct field is found. It is not currently possible to modify `"github-app"` or `"github"` fields. Fixes #3509
blkt
added a commit
that referenced
this issue
Jun 19, 2024
Update command allows changing configuration for provider on a per-field basis. It operates on a read-modify-write fashion, retrieving current configuration from the backend for modification. Modification is done by reflection by walking over the struct's JSON tags. Implementation is recursive, but the maximum depth is determined by the deepest field in the configuration struct. Argument parsing is trivial and assumes that arguments are either of the form `field1.field2.field3` (for `--unset-attribute`) or field1.field2.field3=value` (for `--set-attribute`). The right parser for `value` is determined once the correct struct field is found. It is not currently possible to modify `"github-app"` or `"github"` fields. Fixes #3509
10 tasks
blkt
added a commit
that referenced
this issue
Jun 19, 2024
Update command allows changing configuration for provider on a per-field basis. It operates on a read-modify-write fashion, retrieving current configuration from the backend for modification. Modification is done by reflection by walking over the struct's JSON tags. Implementation is recursive, but the maximum depth is determined by the deepest field in the configuration struct. Argument parsing is trivial and assumes that arguments are either of the form `field1.field2.field3` (for `--unset-attribute`) or field1.field2.field3=value` (for `--set-attribute`). The right parser for `value` is determined once the correct struct field is found. It is not currently possible to modify `"github-app"` or `"github"` fields. Fixes #3509
blkt
added a commit
that referenced
this issue
Jun 20, 2024
Update command allows changing configuration for provider on a per-field basis. It operates on a read-modify-write fashion, retrieving current configuration from the backend for modification. Modification is done by reflection by walking over the struct's JSON tags. Implementation is recursive, but the maximum depth is determined by the deepest field in the configuration struct. Argument parsing is trivial and assumes that arguments are either of the form `field1.field2.field3` (for `--unset-attribute`) or field1.field2.field3=value` (for `--set-attribute`). The right parser for `value` is determined once the correct struct field is found. It is not currently possible to modify `"github-app"` or `"github"` fields. Fixes #3509
blkt
added a commit
that referenced
this issue
Jun 20, 2024
Update command allows changing configuration for provider on a per-field basis. It operates on a read-modify-write fashion, retrieving current configuration from the backend for modification. Modification is done by reflection by walking over the struct's JSON tags. Implementation is recursive, but the maximum depth is determined by the deepest field in the configuration struct. Argument parsing is trivial and assumes that arguments are either of the form `field1.field2.field3` (for `--unset-attribute`) or field1.field2.field3=value` (for `--set-attribute`). The right parser for `value` is determined once the correct struct field is found. It is not currently possible to modify `"github-app"` or `"github"` fields. Fixes #3509
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After we merge PR #3468 we'll get the means to patch provider config via a call. But we also need to expose this functionality through the CLI so that the users could patch their configs.
The text was updated successfully, but these errors were encountered: