Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how-to for pull request remediations #1470

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

rdimitrov
Copy link
Member

No description provided.

@rdimitrov rdimitrov self-assigned this Nov 4, 2023

If a repository does not have Dependabot enabled, Minder will create a pull request with the necessary configuration
to enable it. Alongside the PR, Minder will also create a Security Advisory alert that will be present until the issue
is resolved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should say two things, in a section on limitations:

  1. currently the PR remediations can only set file contents, not merge
  2. if the failing rule is resolved by other means mediator won't close the PR at the moment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll them later today

@rdimitrov rdimitrov merged commit a216495 into mindersec:main Nov 5, 2023
1 check passed
@rdimitrov rdimitrov deleted the pull-request-rem branch November 5, 2023 20:28
@evankanderson evankanderson mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants