Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add X-Forwarded-For to default logging #1670

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Add X-Forwarded-For to default logging #1670

merged 1 commit into from
Nov 16, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 15, 2023

This allows us to get this info in the logs.

@JAORMX
Add X-Forwarded-For to default logging
1189324 
This allows us to get this info in the logs.
@JAORMX JAORMX requested a review from jhrozek November 15, 2023 20:37
jhrozek
jhrozek approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good, let's try this in staging

@JAORMX JAORMX merged commit 89a102b into main Nov 16, 2023
13 checks passed
@JAORMX JAORMX deleted the forwarded-logs branch November 16, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JAORMX @jhrozek