Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade otelgrpc to v0.46.1 #1689

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Upgrade otelgrpc to v0.46.1 #1689

merged 1 commit into from
Nov 17, 2023

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Nov 17, 2023

The otelgrpc upstream fixed a recent regression which allows us to
upgrade to the latest version.

The otelgrpc upstream fixed a recent regression which allows us to
upgrade to the latest version.
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minder analyzed this PR and found no vulnerable dependencies.

@jhrozek
Copy link
Contributor Author

jhrozek commented Nov 17, 2023

the grpc metrics seem to work well now:

minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="0"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="5"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="10"} 5
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="25"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="50"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="75"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="100"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="250"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="500"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="750"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="1000"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="2500"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="5000"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="7500"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="10000"} 8
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="+Inf"} 8
minder_rpc_server_duration_milliseconds_sum{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc"} 77.227207
minder_rpc_server_duration_milliseconds_count{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.1",rpc_grpc_status_code="0",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc"} 8

@jhrozek jhrozek merged commit 45c3e62 into mindersec:main Nov 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants