Return only the raw evaluation error message without prefix #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment we store any evaluation error as `string(err)` which is great for its simplicity and allows us to unwrap the error and test it with `errors.Is` or `errors.As`, but the string representation also includes the string representation of the error itself. In order to both support unwrapping but also be able to extract only the raw message from the evaluator, let's add a `EvaluationError` structure that implements the error interface so it can be tested for with `As`, unwraps into base which is `ErrEvaluationFailed` through the usual `NewErrEvaluationFailed`. The user-visible result is that the errors are no longer stored with the `evaluation failure` prefix, but raw, which will be useful for storing JSON in the result.
JAORMX
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we store any evaluation error as
string(err)which isgreat for its simplicity and allows us to unwrap the error and test it
with
errors.Isorerrors.As, but the string representation alsoincludes the string representation of the error itself.
In order to both support unwrapping but also be able to extract only the
raw message from the evaluator, let's add a
EvaluationErrorstructurethat implements the error interface so it can be tested for with
As,unwraps into base which is
ErrEvaluationFailedthrough the usualNewErrEvaluationFailed.The user-visible result is that the errors are no longer stored with the
evaluation failureprefix, but raw, which will be useful for storingJSON in the result.