Make sure each call to NewRand is initialized with a unique seed #1787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352.
There are several potential locations to fix this, but I think this proposed change helps to remedy other tests that rely on random values.
I tested on the main branch to reproduce the flakiness as follows:
for i in {1..10} ; do go test -count 1 ./internal/db/... ; done
I consistently get an error similar to the following (but mostly not at the first run):
Hence resulting
STATEMENT: -- name: CreateOrganization :one
andSTATEMENT: -- name: CreateProject :one
to fail, similar to #1352.With this change, run the above test (with or without -race) is successful: