Add subcommand to apply profiles #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `minder profile apply` sub-command. It also adds some handy utility functions to simplify writing other profile sub-commands such as `profile create`. Closes: #1756
rdimitrov
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Awesome! 🚀
Not affecting this PR, but have you considered making some of the flags persistent? I know there's a separate issue and this is not part of this scope, just asking so we know if we should visit this command/sub-command pair or it's already covered.
|
@rdimitrov I think we could start making them persistent, but we could do that as part of addressing that PR. |
You're right, let's finish all of this first so we have everything we have to update in the other issue afterwards 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
minder profile applysub-command. It also addssome handy utility functions to simplify writing other profile
sub-commands such as
profile create.Closes: #1756