Remove commit lint job #1817
Merged
Remove commit lint job #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it seemed like a handy idea to lint commit, it turns out that the job itself is not actually used by this project by the fact that we squash the commits before merging. This bypasses the lint job in the end. On the other hand, some of the guidelines like title lengths and commit lengths ended up being controversial. We'll revisit this with a CI job that checks for PR messages instead.
eleftherias
approved these changes
Dec 5, 2023
rdimitrov
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it seemed like a handy idea to lint commit, it turns out that the
job itself is not actually used by this project by the fact that we
squash the commits before merging. This bypasses the lint job in the end.
On the other hand, some of the guidelines like title lengths and commit
lengths ended up being controversial. We'll revisit this with a CI
job that checks for PR messages instead.