Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set go version to 1.22, tweak coverage #2630

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Set go version to 1.22, tweak coverage #2630

merged 5 commits into from
Mar 14, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Mar 13, 2024

We have decided to exclude anything under cmd for coverage since we do not want to rely on unit testing for the CLI.

Go 1.22 reimplements the coverage tool. Unfortunately, the new implementation has a bug. Disable the new coverage logic for now.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We have decided to exclude anything under cmd for coverage since we do
not want to rely on unit testing for the CLI.

Go 1.22 reimplements the coverage tool. Unfortunately, the new
implementation has a bug. Disable the new coverage logic for now.
@dmjb dmjb marked this pull request as ready for review March 13, 2024 15:30
@dmjb dmjb requested a review from a team as a code owner March 13, 2024 15:30
@coveralls
Copy link

coveralls commented Mar 13, 2024

Coverage Status

coverage: 46.504% (+5.9%) from 40.582%
when pulling 81f0c81 on go-1.22
into 9f0b994 on main.

@dmjb dmjb merged commit 49b1977 into main Mar 14, 2024
20 checks passed
@dmjb dmjb deleted the go-1.22 branch March 14, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants