Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider store and provider manager code to create new providers #3377

Merged
merged 4 commits into from
May 20, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented May 20, 2024

Summary

For both the provider auto-enrollment feature and for the OCI providers, we need
to create providers in the database. This PR implements the required provider store
and provider manager changes and will be followed by a patch to expose the functionality
through an RPC call.

Related: #3376

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

unit tests and as part of a larger patchset

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek jhrozek requested a review from a team as a code owner May 20, 2024 14:39
@coveralls
Copy link

coveralls commented May 20, 2024

Coverage Status

coverage: 49.828% (-0.1%) from 49.955%
when pulling d77e9ee on jhrozek:provider_manager_create
into 2d7e6b3 on stacklok:main.

@jhrozek
Copy link
Contributor Author

jhrozek commented May 20, 2024

btw the test coverage will go up again in the next PR (testing some of the code here is actually more thorough through the RPC handler)

@jhrozek jhrozek merged commit e554e73 into mindersec:main May 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants