Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous lookup in github webhook handler. #3403

Merged
merged 1 commit into from
May 22, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented May 22, 2024

Summary

While adding tests I erroneously changed a lookup in a package event json from ".package.package_version.container_metadata.tag.name" to ".package.package_version.tag_name", which turned out to be both (a) the wrong thing to do and (b) causing an internal server error because "tag_name" field is not available (anymore?) for package events.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this May 22, 2024
@coveralls
Copy link

coveralls commented May 22, 2024

Coverage Status

coverage: 51.921%. remained the same
when pulling 5419a37 on fix-webhook-lookup-failure
into e707a98 on main.

@blkt blkt force-pushed the fix-webhook-lookup-failure branch from b75e0ad to f9d3431 Compare May 22, 2024 10:26
@blkt blkt marked this pull request as ready for review May 22, 2024 10:26
@blkt blkt requested a review from a team as a code owner May 22, 2024 10:26
JAORMX
JAORMX previously approved these changes May 22, 2024
While adding tests I erroneously changed a lookup in a package event
json from ".package.package_version.container_metadata.tag.name" to
".package.package_version.tag_name", which turned out to be both (a)
the wrong thing to do and (b) causing an internal server error because
"tag_name" field is not available (anymore?) for package events.
@blkt blkt merged commit 04db03c into main May 22, 2024
21 checks passed
@blkt blkt deleted the fix-webhook-lookup-failure branch May 22, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants