Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fallback key ID when key version is empty #3482

Merged
merged 4 commits into from
May 31, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented May 31, 2024

This addresses a bug preventing the decryption of old secrets when the default key has been rotated.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This addresses a bug preventing the decryption of old secrets when the
default key has been rotated.
@dmjb dmjb requested a review from a team as a code owner May 31, 2024 10:24
JAORMX
JAORMX previously approved these changes May 31, 2024
JAORMX
JAORMX previously approved these changes May 31, 2024
@coveralls
Copy link

coveralls commented May 31, 2024

Coverage Status

coverage: 52.362% (+0.02%) from 52.342%
when pulling 48df42c on fix-default-algorithm-empty-string
into f8c48ba on main.

@dmjb dmjb merged commit 2934f33 into main May 31, 2024
20 checks passed
@dmjb dmjb deleted the fix-default-algorithm-empty-string branch May 31, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants