Marshall provider config back to JSON from parsed structures to strip extra keys #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or else we risk people updating junk up to our configured limit and polluting our database Fixes: mindersec#3543
|
Changes unknown |
rdimitrov
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now, we parse the user-provided provider configuration, but if it passes validation, we save the user-provided config verbatim. This means that if there are any extra keys, we save them as well because Go ignores extra attributes when unmarshalling JSON.
We need to fix this or else we risk our users flood our database with large configs.
Credit to @blkt for bringing this up.
Fixes #3543
Change Type
Testing
manual + make test
Review Checklist: