Add project_id column to rule_instances #3570
Conversation
This provides a more elegant solution to the `ON CASCADE DELETE` problem.
There was a problem hiding this comment.
Overall, I like this simplification. Maybe we're okay at the moment with causing minder failures during rollout due to adding NOT NULL columns to the schema, but I wanted to check.
If you want to split it up, I would add the column with no constraints and the new queries, and then do a second migration PR that does the backfill and adds the constraint.
| WHERE ri.profile_id = pf.id; | ||
|
|
||
| -- now we can add the not null constraint | ||
| ALTER TABLE rule_instances ALTER COLUMN project_id SET NOT NULL; |
There was a problem hiding this comment.
Won't this cause current-minder to fail after the DB migration until the new deployment occurs?
There was a problem hiding this comment.
Good point, will remove this.
| BEGIN; | ||
|
|
||
| -- add column, leave as not null until we populate the column | ||
| ALTER TABLE rule_instances ADD COLUMN project_id UUID REFERENCES projects(id) ON DELETE CASCADE; |
There was a problem hiding this comment.
Do we want or need an index on project_id here?
There was a problem hiding this comment.
At this point in time, we don't use the new column in the queries since the tuple of (name, profile_id, entity_type) is still unique. As I add more queries, I will add more indices based on common query patterns.
dmjb
force-pushed
the
rule_instance_project_id_fk
branch
2 times, most recently
from
e10f877
to
136703e
Compare
dmjb
force-pushed
the
rule_instance_project_id_fk
branch
from
136703e
to
62d6507
Compare
This provides a more elegant solution to the
ON CASCADE DELETEproblem with therule_instancetable. Tested locally.Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: