Handle the old key when writing configuration, but write the new one #3575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our current configuration key for the GH app provider is "github-app" which
is problematic to use as a key in protobuf. Let's rename the key to
"github_app", but do it in steps - first, this patch ensures that any
new providers are written with underscore, but the old providers
continue to work. As the next step, we're going to migrate the database
records in order to not risk a race where we migrate the database but
the code would still be creating providers with the old key.
Related: #3569
Change Type
Mark the type of change your PR introduces:
Testing
manual + adjusted unit tests
Review Checklist: