Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define evaluation metrics #3688

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Define evaluation metrics #3688

merged 3 commits into from
Jun 24, 2024

Commits on Jun 21, 2024

  1. Define evaluation metrics

    Add in some basic metrics to track rule/entity evaluations to the
    engine. Note that the metrics for alerts and remediations are not wired
    in yet since they depend on some changes which will be added in the next
    PR.
    
    I have taken a different approach to handling noop metrics than is used
    in the codebase so far: instead of defining an interface and separate
    real vs noop implementations, I have decided to make use of the noop
    metrics handling built into otel: there is now a metrics meter factory
    with alternative implementation for noop vs "real" metrics. Any part of
    the code which needs to create metrics can use the factory without
    caring whether the metrics are actually exported or not.
    
    Relates to: #3556
    dmjb committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    834f355 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1209d30 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Configuration menu
    Copy the full SHA
    03c021a View commit details
    Browse the repository at this point in the history