Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rule_instances table in CountProfilesByEntityType query #3904

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 16, 2024

This further reduces our use of the entity_profiles table, which I am currently working towards removing.

New query evaluated by running it against both my local env and staging, and comparing to the result of the query it replaced. Note that it is only used for populating metrics.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner July 16, 2024 14:08
@dmjb dmjb force-pushed the count-entity-type-metric branch from 91f9f80 to 9054c28 Compare July 16, 2024 14:13
dmjb added 2 commits July 16, 2024 15:13
This further reduces our use of the `entity_profiles` table, which I am
currently working towards removing.
@dmjb dmjb force-pushed the count-entity-type-metric branch from 9054c28 to 7fea638 Compare July 16, 2024 14:13
@coveralls
Copy link

coveralls commented Jul 16, 2024

Coverage Status

coverage: 53.655%. remained the same
when pulling b21fd6f on count-entity-type-metric
into a175dd9 on main.

@dmjb dmjb merged commit 96efacb into main Jul 16, 2024
20 checks passed
@dmjb dmjb deleted the count-entity-type-metric branch July 16, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants