Allow authenticated users without Minder projects to accept credentials #3909
Conversation
|
@kantord -- this changes the flow such that we don't need to call |
cmd/cli/app/auth/common.go
Outdated
There was a problem hiding this comment.
Most of the remainder of this file is common table-rendering code, which I left in place because I didn't want to move too much at once.
internal/util/cli/rpc_client.go
Outdated
There was a problem hiding this comment.
This didn't have tests before when it was in cmd/cli/app/auth, but it shows up in coverage now, because it's in internal. I think that's fair, but I'm not prepared to write tests for it yet.
| return nil | ||
| // Create a user if necessary, see https://github.com/stacklok/minder/pull/3837/files#r1674108001 | ||
| if errors.Is(err, sql.ErrNoRows) { | ||
| return store.CreateUser(ctx, sub) |
There was a problem hiding this comment.
There is an edge case where the invited user will also have installed the GitHub App from the Marketplace, in which case we would want to call claimGitHubInstalls as well.
There was a problem hiding this comment.
Ah, good catch! Fixing!
…vite and creating a Minder account
Summary
See discussion here: #3837 (comment)
When a user is invited to a project (and they haven't used Minder before),
minder auth invite accept <code>should set up what they need to use theinvited project, without requiring them to call
CreateUserand set up a"personal project".
Along the way, I ended up moving the login functions to
internal/util/cli,because it felt strange to have a bunch of shared logic in
cmd/cli/app/auth.Fixes #3795
Change Type
Mark the type of change your PR introduces:
Testing
Added a unit test and tested manually with the new
minder auth invite accept.Review Checklist: