Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListEvaluationHistory RPC faulty navigation to next page. #3967

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 23, 2024

Summary

The SQL statement underlying ListEvaluationHistory RPC has fixed sorting. This does not create problems when navigating in the same direction, but creates problem when changing direction from pages further away from the first.

This change solves the issue by determining the sort direction dynamically and inverting the records at the service layer accordingly.

Fixes #3966

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Added test case.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Jul 23, 2024
@blkt blkt requested a review from a team as a code owner July 23, 2024 15:39
The SQL statement underlying ListEvaluationHistory RPC has fixed
sorting. This does not create problems when navigating in the same
direction, but creates problem when changing direction from pages
further away from the first.

This change solves the issue by determining the sort direction
dynamically and inverting the records at the service layer
accordingly.

Fixes #3966
@coveralls
Copy link

coveralls commented Jul 23, 2024

Coverage Status

coverage: 54.235% (+0.002%) from 54.233%
when pulling f16ae49 on issue-3966
into 9498645 on main.

@blkt blkt merged commit 2b5bb5d into main Jul 23, 2024
20 checks passed
@blkt blkt deleted the issue-3966 branch July 23, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListEvaluationHistory RPC navigation to next page is faulty
3 participants