Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill entity_type in evaluation_rule_entities #3996

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 25, 2024

This change backfills the entity_type column and makes it non nullable. The DB query used for listing evaluation history is also changed to use this column.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@coveralls
Copy link

coveralls commented Jul 25, 2024

Coverage Status

coverage: 54.626% (-0.001%) from 54.627%
when pulling 4ad5053 on migrate-entity-type
into c7a8e15 on main.

This backfill this column and makes it non nullable. The DB query used
for listing evaluation history is also changed to use this column.
@dmjb dmjb marked this pull request as ready for review July 29, 2024 11:38
@dmjb dmjb requested a review from a team as a code owner July 29, 2024 11:38
@dmjb dmjb merged commit eec1a30 into main Jul 29, 2024
22 checks passed
@dmjb dmjb deleted the migrate-entity-type branch July 29, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants