Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule_instance_id column on rule_evaluations #4103

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Aug 7, 2024

When this column was backfilled originally, the update statement lacked some of the fields needed to make sure that the join from rule_evaluations to rule_instances was a 1-1 mapping. This led to the wrong rule_instance_id being attached to the rule_evaluations table. Note that this value is not currently used for anything, so the impact was negligible.

This re-runs the backfill with all fields matching to ensure the correct ID is used.

Validated in staging.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner August 7, 2024 15:54
@coveralls
Copy link

coveralls commented Aug 7, 2024

Coverage Status

coverage: 54.402%. remained the same
when pulling eb2f5cf on fix-rule-instance-id-mapping
into 7ac7423 on main.

@dmjb dmjb force-pushed the fix-rule-instance-id-mapping branch from 456f4ba to 3a6d08a Compare August 7, 2024 16:57
When this column was backfilled originally, the update statement lacked
some of the fields needed to make sure that the join from
rule_evaluations to rule_instances was a 1-1 mapping. This led to the
wrong rule_instance_id being attached to the rule_evaluations table.
Note that this value is not currently used for anything, so the impact
was negligible.

This re-runs the backfill with all fields matching to ensure the correct
ID is used.
@dmjb dmjb force-pushed the fix-rule-instance-id-mapping branch from 6b6f323 to eb2f5cf Compare August 8, 2024 10:46
@dmjb dmjb merged commit 082572d into main Aug 8, 2024
22 checks passed
@dmjb dmjb deleted the fix-rule-instance-id-mapping branch August 8, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants