Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for profile selectors #4120

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Ref #4018

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner August 12, 2024 13:15
@coveralls
Copy link

coveralls commented Aug 12, 2024

Coverage Status

coverage: 53.891% (-0.008%) from 53.899%
when pulling c3ba16b on eleftherias:4018-selectors-docs
into 98c9331 on stacklok:main.


| Field | Description | Type |
|--------------|-----------------------------------------------------------------------------------------------------|------------------|
| `name` | The full name of the repository, e.g. stacklok/minder | string |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Do we want to explicitly call out that wildcards and partials are not supported, or do you feel this is sufficient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any kind of wildcard support would need to be part of CEL, so I've left it out of our docs

jhrozek
jhrozek previously approved these changes Aug 12, 2024
docs/docs/how-to/profile_selectors.md Outdated Show resolved Hide resolved
@eleftherias eleftherias merged commit ac6f744 into mindersec:main Aug 13, 2024
18 of 19 checks passed
@eleftherias eleftherias deleted the 4018-selectors-docs branch August 13, 2024 12:52
psekar pushed a commit to tinytrail/minder that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants