Move properties fetcher methods into Provider #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrozek
reviewed
Aug 16, 2024
| // FetchAllProperties implements the provider interface | ||
| // TODO: Implement this | ||
| func (_ *dockerHubImageLister) FetchAllProperties(_ context.Context, _ string, _ minderv1.Entity) (*properties.Properties, error) { | ||
| return nil, nil |
There was a problem hiding this comment.
todo for me: Handle nil receiver on Properties (Property already does)
jhrozek
reviewed
Aug 16, 2024
| @@ -36,9 +36,6 @@ type REST struct { | |||
| credential provifv1.RestCredential | |||
| } | |||
|
|
|||
| // Ensure that REST implements the REST interface | |||
| var _ provifv1.REST = (*REST)(nil) | |||
There was a problem hiding this comment.
why do we need to remove these?
There was a problem hiding this comment.
so, REST and Git are not actually providers, but helper code that providers use to implement the relevant traits. I was thinking it would be good to start migrating away from these "trying" to implement the provider interface. This gets a little tricky, as we do treat them as providers in some test code, so I might just create a provider wrapper that uses these.
jhrozek
reviewed
Aug 16, 2024
| // FetchAllProperties fetches all properties for the given entity | ||
| FetchAllProperties(ctx context.Context, name string, entType minderv1.Entity) (*properties.Properties, error) | ||
| // FetchProperty fetches a single property for the given entity | ||
| FetchProperty(ctx context.Context, name string, entType minderv1.Entity, key string) (*properties.Property, error) |
JAORMX
force-pushed
the
fetcher-provider
branch
from
15e572a
to
a5adbd8
Compare
Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
fetcher-provider
branch
from
a5adbd8
to
d279d90
Compare
JAORMX
changed the title
jhrozek
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This effectively enforces that providers must implement properties fetching as part of their implementation.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: