Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store repo license again #4190

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Store repo license again #4190

merged 1 commit into from
Aug 19, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Aug 19, 2024

Summary

We used to store repo license since
5a78abc but then stopping saving the
attribute in d68e8e6. We still have
ruletypes that rely on that attribute, so let's just re-add it.

Side-note: Saving generic attributes will get way easier once we
implement properties fully.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

manually

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We used to store repo license since
5a78abc but then stopping saving the
attribute in d68e8e6. We still have
ruletypes that rely on that attribute, so let's just re-add it.

Side-note: Saving generic attributes will get way easier once we
implement properties fully.
@jhrozek jhrozek requested a review from a team as a code owner August 19, 2024 06:24
@jhrozek
Copy link
Contributor Author

jhrozek commented Aug 19, 2024

hmm, it should be possible to write a unit test. I should add a test case, sorry!

@coveralls
Copy link

Coverage Status

coverage: 53.935% (-0.002%) from 53.937%
when pulling 417c7e1 on jhrozek:license_attr
into 4083e3f on stacklok:main.

@jhrozek jhrozek merged commit ca914f1 into mindersec:main Aug 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants