Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle int64 and uint64 in properties by wrapping it #4253

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Aug 22, 2024

Summary

We started using structpb.Value to hold the payload of our properties,
but since the Value type is expected to be directly serialized to a JSON
value, all numerical values are treated as float64.

Because we also want to store int64 values, we need to treat them
separately, by storing them as objects instead with the integer value
stringified.

Related: #4171

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

mostly unit tests

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We started using structpb.Value to hold the payload of our properties,
but since the Value type is expected to be directly serialized to a JSON
value, all numerical values are treated as float64.

Because we also want to store int64 values, we need to treat them
separately, by storing them as objects instead with the integer value
stringified.

Related: mindersec#4171
@coveralls
Copy link

Coverage Status

coverage: 53.838% (+0.1%) from 53.716%
when pulling 1298886 on jhrozek:prop_int64
into b30ca2e on stacklok:main.

@jhrozek jhrozek merged commit 531e326 into mindersec:main Aug 23, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants