Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite UserVisibleError when updating selectors fails #4334

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Aug 30, 2024

Summary

We would return a UserVisibleError when updating selectors, but then
overwrite it in the caller who caled the validation, which resulted in
the server returning a 500 HTTP code to the client.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

curl -XPUT -vv -H "Authorization: Bearer $MINDER_BEARER_TOKEN" 'http://localhost:8080/api/v1/profile' --data-binary @/Users/jakub/devel/playground/selectors/repro.json

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We would return a UserVisibleError when updating selectors, but then
overwrite it in the caller who caled the validation, which resulted in
the server returning a 500 HTTP code to the client.
@jhrozek jhrozek merged commit b1f13f9 into mindersec:main Aug 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants