Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the properties timeout #4347

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Bump the properties timeout #4347

merged 1 commit into from
Sep 3, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 3, 2024

Summary

We started seeing too many requests to upstream. Increasing the timeout
might alleviate that as long as we're requesting the same properties.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

N/A

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We started seeing too many requests to upstream. Increasing the timeout
might alleviate that as long as we're requesting the same properties.
@coveralls
Copy link

Coverage Status

coverage: 53.287%. remained the same
when pulling db5be63 on jhrozek:bump_timeout
into f6bff2f on stacklok:main.

@jhrozek jhrozek merged commit 095ccd8 into mindersec:main Sep 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants