Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EEA: Only lock if entity instance exists in a transaction #4388

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Sep 6, 2024

Summary

This changes the logic to check that an entity exists as part of a transaction
before trying to lock it in the EEA. This way we'd avoid race conditions of trying
to lock an entity that gets deleted at the same time.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This brings back the logic to verify if an entity exists before trying
to lock it in the EEA. This accidentally went away when I stopped using
the per-entity columns in the EEA.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX changed the title EEA: Only lock if entity instance exists EEA: Only lock if entity instance exists in a transaction Sep 6, 2024
@coveralls
Copy link

Coverage Status

coverage: 53.669% (+0.02%) from 53.647%
when pulling d595513 on eea-entity-instance-get
into 1f9c1ef on main.

@JAORMX JAORMX merged commit bec2b46 into main Sep 6, 2024
23 checks passed
@JAORMX JAORMX deleted the eea-entity-instance-get branch September 6, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants