Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties to Repositories protobuf message #4406

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Sep 9, 2024

Summary

This adds properties which will allow us to output the entity properties
as we're gathering them. Even though we're hoping to get rid of the
Repositories message entirely, this is handy to have while we make the
transition.

Note that there is nothing outputting this nor using this at the moment.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This adds properties which will allow us to output the entity properties
as we're gathering them. Even though we're hoping to get rid of the
`Repositories` message entirely, this is handy to have while we make the
transition.

Note that there is nothing outputting this nor using this at the moment.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX merged commit dfbd471 into main Sep 9, 2024
23 checks passed
@JAORMX JAORMX deleted the repo-properties branch September 9, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants