properties service: Don't double query for entity information #4443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
force-pushed
the
rm-double-query
branch
from
f2d6aeb
to
e47f9da
Compare
`RetrieveAllPropertiesForEntity` is not as optimal as it could be. At the point where it's called, we've already retrieved an entity and have all relevant data. We then call `RetrieveAllProperties` from within and re-fetch the entity data... that's not ideal. This fixes that. Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
rm-double-query
branch
from
e47f9da
to
8f62a14
Compare
jhrozek
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RetrieveAllPropertiesForEntityis not as optimal as it could be. At the point where it's called,we've already retrieved an entity and have all relevant data. We then call
RetrieveAllPropertiesfrom within and re-fetch the entity data... that's not ideal. This fixes that.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: