Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request id to logs. #4461

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Add request id to logs. #4461

merged 2 commits into from
Oct 16, 2024

Commits on Oct 15, 2024

  1. Add request id to logs. 

    This change adds a GRPC interceptor that fetches the header
`Grpc-Metadata-Request-Id` and adds it to the logger. It also returns
the request id to the client in the trailer, which is helpful for
debugging.

CLI command `minder history list` was modified to show its usage, but
those changes should be reverted.
    @blkt
    blkt committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f48342c View commit details
    Browse the repository at this point in the history

  2. Make server decide the value of request-id. 

    Also, use header rather than trailer.
    @blkt
    blkt committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f2b1f94 View commit details
    Browse the repository at this point in the history