Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing extension to docs links #4494

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Add missing extension to docs links #4494

merged 1 commit into from
Sep 17, 2024

Conversation

danbarr
Copy link
Contributor

@danbarr danbarr commented Sep 16, 2024

Summary

The new rule evaluations page added in #4481 has three links to the secret_scanning rule page that are missing the .md extension. These worked in the minder-docs.stacklok.dev build but caused the Docusaurus build to fail on a broken link error for the cloud docs overlay.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Confirmed links are working via local preview.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek jhrozek merged commit 1f9a363 into main Sep 17, 2024
20 checks passed
@jhrozek jhrozek deleted the danbarr/rule-link-fix branch September 17, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants