Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove database access from the github webhook, use message passing instead #4495

Closed
wants to merge 7 commits into from

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 16, 2024

Summary

This is a large draft and I'm going to split it up. Manual testing works and I've been
adding/fixing tests and fixing various issues.

I will un-draft once I've finished testing, added unit tests for new code and the smoke tests passed locally.

  • Remove unused setters of repoID attribute for entity reconciliation
  • Use generic property keys instead of repoName/repoOwner when adding repos
  • Add two more generic methods for EntityInfoWrapper
  • Rename EntityWithProperties to EntityWithPropertiesByID
  • Add EntityWithPropertiesByUpstreamID
  • Add handler
  • Use handler

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

so far just manual that's why it's a draft.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek
Copy link
Contributor Author

jhrozek commented Sep 30, 2024

I'm closing this PR in favor of opening smaller ones like #4565 which allow for better testing and easier rollback/revert if needed.

@jhrozek jhrozek closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant