Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appropriate logging functions were possible #4523

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Use appropriate logging functions were possible #4523

merged 1 commit into from
Sep 18, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Sep 18, 2024

Summary

I noticed a lot of usages of fmt.Printf or fmt.Println throughout
the codebase. While this does the trick, it loses a lot of context that
we'd ideally have.

This switches to using logging functions that keep context and give us
extra data that's useful for debugging.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

I noticed a lot of usages of `fmt.Printf` or `fmt.Println` throughout
the codebase. While this does the trick, it loses a lot of context that
we'd ideally have.

This switches to using logging functions that keep context and give us
extra data that's useful for debugging.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@coveralls
Copy link

Coverage Status

coverage: 52.845% (-0.03%) from 52.871%
when pulling 55d5c2b on no-fmt-printf
into 3cd5378 on main.

@JAORMX JAORMX merged commit 9054b74 into main Sep 18, 2024
22 checks passed
@JAORMX JAORMX deleted the no-fmt-printf branch September 18, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants