Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the name of the package for which we couldn't find a fix #4524

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 18, 2024

Summary

When replying to a single line, github always prepends the context "before"
the line unless replying with a suggestion. This gets confusing when replying
to a line deeper in a diff especially the last line as we can't pinpoint a
single line to reply to.

To improve the UX a little bit, we include the package name with the
package we are replying to so that the user can tie the comment better
to the actual line.

Pair-Programmed-With: Michelangelo Mori [email protected]

Fixes: #4529

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

manual

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

blkt
blkt previously approved these changes Sep 18, 2024
JAORMX
JAORMX previously approved these changes Sep 18, 2024
When replying to a single line, github always prepends the context "before"
the line unless replying with a suggestion. This gets confusing when replying
to a line deeper in a diff especially the last line as we can't pinpoint a
single line to reply to.

To improve the UX a little bit, we include the package name with the
package we are replying to so that the user can tie the comment better
to the actual line.

Pair-Programmed-With: Michelangelo Mori <[email protected]>
@jhrozek
Copy link
Contributor Author

jhrozek commented Sep 18, 2024

@JAORMX @blkt thanks for the quick review, I just fixed another unit test that was expecting the old comment

JAORMX
JAORMX previously approved these changes Sep 18, 2024
@coveralls
Copy link

coveralls commented Sep 18, 2024

Coverage Status

coverage: 52.839% (-0.002%) from 52.841%
when pulling b7f908e on jhrozek:osv_comment_improve
into 9054b74 on stacklok:main.

blkt
blkt previously approved these changes Sep 18, 2024
@jhrozek jhrozek merged commit fabeea9 into mindersec:main Sep 18, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When replying to a package that has no fix, minder doesn't tell which package which gets confusing in the diff
4 participants