Add new watermill handlers that get or refresh entities by properties and call another handler #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrozek
force-pushed
the
webhook_generic_handler
branch
from
6252c1f
to
965442a
Compare
jhrozek
force-pushed
the
webhook_generic_handler
branch
2 times, most recently
from
d5b3a6f
to
a93a3f4
Compare
|
I split the code into multiple sub-packages with smaller files so it's easier to digest |
jhrozek
force-pushed
the
webhook_generic_handler
branch
2 times, most recently
from
ba5a06d
to
ceaa2f8
Compare
|
There are no functional changes in the latest push, just beefing up the test coverage. Almost there! |
JAORMX
previously approved these changes
Sep 20, 2024
JAORMX
reviewed
Sep 20, 2024
| // HandleEntityAndDoMessage is a message that is sent to the entity handler to refresh an entity and perform an action. | ||
| type HandleEntityAndDoMessage struct { | ||
| Entity TypedProps `json:"entity"` | ||
| Owner TypedProps `json:"owner"` |
There was a problem hiding this comment.
Owner can be a little confusing (at first I thought we were conflating GitHub terms again). Can we rename this to originator or begetter?
… and call another handler These will be used in webhook handlers instead of calling the property service directly. The handlers follow the same base logic, just with "pluggable" ways of retrieving the entity, converting the entity to properties and which handler to call next. Related: mindersec#4327
jhrozek
force-pushed
the
webhook_generic_handler
branch
from
ceaa2f8
to
238f52f
Compare
JAORMX
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These will be used in webhook handlers instead of calling the property
service directly. The handlers follow the same base logic, just with
"pluggable" ways of retrieving the entity, converting the entity to
properties and which handler to call next.
The test coverage is not great yet, but I did test the handlers manually
outside the tests I have in another branch and they seemed to work well.
I will be adding more tests as this PR is reviewed.
Related: #4327
Change Type
Testing
some unit tests are added in this PR, but I'll add more. Most of the testing has been manual as part of another branch.
Review Checklist: