Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump github.com/thomaspoignant/go-feature-flag from 1.34.0 to 1.34.2 (#4552)" #4556

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 20, 2024

Summary

This reverts commit 5808615.

This upgrade brought OTEL dependencies along which cause minder to
crash:

goroutine 141 [running]:
go.opentelemetry.io/otel/internal/global.(*registration).setDelegate(0x140003e4e40, {0x10727f0c8, 0x1400077e420})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/meter.go:492 +0x19c
go.opentelemetry.io/otel/internal/global.(*meter).setDelegate(0x140004d0b40, {0x10724f6b8?, 0x14000787130?})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/meter.go:138 +0x1d8
go.opentelemetry.io/otel/internal/global.(*meterProvider).setDelegate(0x140003226f0, {0x10724f6b8, 0x14000787130})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/meter.go:47 +0x168
go.opentelemetry.io/otel/internal/global.SetMeterProvider.func1()
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/state.go:171 +0x3c
sync.(*Once).doSlow(0x1?, 0x1?)
        /Users/jakub/go/pkg/mod/golang.org/[email protected]/src/sync/once.go:76 +0xf8
sync.(*Once).Do(...)
        /Users/jakub/go/pkg/mod/golang.org/[email protected]/src/sync/once.go:67
go.opentelemetry.io/otel/internal/global.SetMeterProvider({0x10724f6b8, 0x14000787130})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/state.go:169 +0x1b4
go.opentelemetry.io/otel.SetMeterProvider(...)
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/metric.go:41
github.com/stacklok/minder/internal/controlplane.initMetrics({0x107266260, 0x1400087db00})
        /Users/jakub/devel/mediator/internal/controlplane/server.go:236 +0x480
github.com/stacklok/minder/internal/controlplane.(*Server).startMetricServer(0x14000714340, {0x107260cd0, 0x140006e0550})
        /Users/jakub/devel/mediator/internal/controlplane/server.go:462 +0x128
github.com/stacklok/minder/internal/controlplane.(*Server).StartHTTPServer.func2()
        /Users/jakub/devel/mediator/internal/controlplane/server.go:394 +0x28
created by github.com/stacklok/minder/internal/controlplane.(*Server).StartHTTPServer in goroutine 88
        /Users/jakub/devel/mediator/internal/controlplane/server.go:393 +0xae0
exit status 2

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

run minder

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

…rom 1.34.0 to 1.34.2 (mindersec#4552)"

This reverts commit 5808615.

This upgrade brought OTEL dependencies along which cause minder to
crash:
```
goroutine 141 [running]:
go.opentelemetry.io/otel/internal/global.(*registration).setDelegate(0x140003e4e40, {0x10727f0c8, 0x1400077e420})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/meter.go:492 +0x19c
go.opentelemetry.io/otel/internal/global.(*meter).setDelegate(0x140004d0b40, {0x10724f6b8?, 0x14000787130?})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/meter.go:138 +0x1d8
go.opentelemetry.io/otel/internal/global.(*meterProvider).setDelegate(0x140003226f0, {0x10724f6b8, 0x14000787130})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/meter.go:47 +0x168
go.opentelemetry.io/otel/internal/global.SetMeterProvider.func1()
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/state.go:171 +0x3c
sync.(*Once).doSlow(0x1?, 0x1?)
        /Users/jakub/go/pkg/mod/golang.org/[email protected]/src/sync/once.go:76 +0xf8
sync.(*Once).Do(...)
        /Users/jakub/go/pkg/mod/golang.org/[email protected]/src/sync/once.go:67
go.opentelemetry.io/otel/internal/global.SetMeterProvider({0x10724f6b8, 0x14000787130})
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/state.go:169 +0x1b4
go.opentelemetry.io/otel.SetMeterProvider(...)
        /Users/jakub/go/pkg/mod/go.opentelemetry.io/[email protected]/metric.go:41
github.com/stacklok/minder/internal/controlplane.initMetrics({0x107266260, 0x1400087db00})
        /Users/jakub/devel/mediator/internal/controlplane/server.go:236 +0x480
github.com/stacklok/minder/internal/controlplane.(*Server).startMetricServer(0x14000714340, {0x107260cd0, 0x140006e0550})
        /Users/jakub/devel/mediator/internal/controlplane/server.go:462 +0x128
github.com/stacklok/minder/internal/controlplane.(*Server).StartHTTPServer.func2()
        /Users/jakub/devel/mediator/internal/controlplane/server.go:394 +0x28
created by github.com/stacklok/minder/internal/controlplane.(*Server).StartHTTPServer in goroutine 88
        /Users/jakub/devel/mediator/internal/controlplane/server.go:393 +0xae0
exit status 2
```
Copy link

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 5baca284:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

@jhrozek jhrozek merged commit a32f58d into mindersec:main Sep 20, 2024
20 checks passed
@coveralls
Copy link

Coverage Status

coverage: 53.131% (+0.008%) from 53.123%
when pulling 5baca28 on jhrozek:revert
into 6a3bef1 on stacklok:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants