Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: Handle query parameters in REST trait #4632

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 3, 2024

Summary

This allows us to reliably pass query parameters in the gitlab REST
trait. Else, we'd get everything URL-encoded and it would not work.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This allows us to reliably pass query parameters in the gitlab REST
trait. Else, we'd get everything URL-encoded and it would not work.

Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX merged commit f21693c into main Oct 3, 2024
19 checks passed
@JAORMX JAORMX deleted the gitlab-rest-query-params branch October 3, 2024 13:44
@coveralls
Copy link

Coverage Status

coverage: 53.015% (+0.04%) from 52.979%
when pulling aba1fd6 on gitlab-rest-query-params
into 554aae4 on main.

@coveralls
Copy link

Coverage Status

coverage: 53.011% (+0.03%) from 52.979%
when pulling aba1fd6 on gitlab-rest-query-params
into 554aae4 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants