-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitlab: Add support for pull requests #4641
Conversation
@jhrozek I ended up changing this so we use the unique gitlab PR ID as the upstream ID, and I added a new property to carry the user-friendly, smaller numbered, ID. The later we actually surface to users. This way, we can do more efficient lookups via the unique ID and there will be less probabilities of needing to fallback to the name. |
fd9ecf9
to
3c3f8e1
Compare
b0de583
to
fb3e5cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of minor comments, LGTM otherwise.
"pull requests" are minder's name for merge request, this adds support for these in the gitlab provider. Signed-off-by: Juan Antonio Osorio <[email protected]>
This enables us to more uniquely identify the PR, while being able to still use the friendly short number. This requires us to carry two IDs in the PR properties. Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
fcacfa3
to
8806f0a
Compare
Signed-off-by: Juan Antonio Osorio <[email protected]>
Summary
"pull requests" are minder's name for merge request, this adds support
for these in the gitlab provider.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: