Add eval details template for deny-by-default rule. #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blkt
force-pushed
the
feat/rego-deny-by-default-eval-details-template
branch
4 times, most recently
from
530b44f
to
d4d4b8e
Compare
blkt
commented
Oct 4, 2024
| @@ -177,7 +177,7 @@ func (r *RuleTypeEngine) Eval( | |||
|
|
|||
| // Process evaluation | |||
| logger.Info().Msg("entity evaluation - evaluation started") | |||
| err := r.ruleEvaluator.Eval(ctx, params.GetRule().Def, result) | |||
| err := r.ruleEvaluator.Eval(ctx, params.GetRule().Def, inf.Entity, result) | |||
There was a problem hiding this comment.
I could turn this into the same pattern as the one used here to limit the changes across the code base, let me know what you folks prefer.
blkt
force-pushed
the
feat/rego-deny-by-default-eval-details-template
branch
from
d4d4b8e
to
db05cd9
Compare
This change adds a template used to produce evaluation details for the `rego/deny-by-default` evaluation engine. This template allows the user defining the rule to output a `message` variable with a custom message to show when the evaluation fails. Fixes stacklok/minder-stories#42
blkt
force-pushed
the
feat/rego-deny-by-default-eval-details-template
branch
from
db05cd9
to
e741b32
Compare
eleftherias
reviewed
Oct 7, 2024
| @@ -0,0 +1 @@ | |||
| Evaluation {{ .status }}: {{ .message }}{{ with .entityName }} for entity {{ . }}{{ end }} | |||
There was a problem hiding this comment.
Based on https://github.com/stacklok/minder-stories/issues/42#issuecomment-2394190172 should this be Evaluation {{ .status }}: {{ .message }}{{ with .entityName }} for {{ . }}{{ end }}?
There was a problem hiding this comment.
Also, should we remove the Evaluation {{ .status }}: prefix? I think all the places that would use this already show the status separately from the details.
There was a problem hiding this comment.
Yes, I might have prematurely optimized for the other cases (non failed ones).
I'll remove that.
eleftherias
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a template used to produce evaluation details for the
rego/deny-by-defaultevaluation engine.This template allows the user defining the rule to output a
messagevariable with a custom message to show when the evaluation fails.Fixes stacklok/minder-stories#42
Change Type
Testing
Unit and manual tested.
Review Checklist: