Add additional test coverage for common functions in GitHub provider

[gajananan]

Summary

Currently common functions in GitHub provider lacks test coverage when converting github repos to minder repos.
This commit adds test coverage for ConvertRepositories for github.

Ref #4380

Change Type

Mark the type of change your PR introduces:

• Bug fix (resolves an issue without affecting existing features)
• Feature (adds new functionality without breaking changes)
• Breaking change (may impact existing functionalities or require documentation updates)
• Documentation (updates or additions to documentation)
• Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

• Reviewed my own code for quality and clarity.
• Added comments to complex or tricky code sections.
• Updated any affected documentation.
• Included tests that validate the fix or feature.
• Checked that related changes are merged.

[coveralls]

coverage: 53.361% (+0.1%) from 53.264%
when pulling dfd73e8 on gajananan:improve-test-coverage-proividers-gh-common
into 49f192a on stacklok:main.

[eleftherias]

Thanks for the PR @gajananan!

The code changes look good, there are just a few cleanup items we need before merging this.
Could you run make lint on you local machine before committing? This will show the lint errors.
Could you change the PR description from Fixes #4380 to Ref #4380? If we have the Fixes keyword then it will close the associated issue, which we don't want in this case.

[gajananan]

Thanks for the PR @gajananan!

The code changes look good, there are just a few cleanup items we need before merging this. Could you run make lint on you local machine before committing? This will show the lint errors. Could you change the PR description from Fixes #4380 to Ref #4380? If we have the Fixes keyword then it will close the associated issue, which we don't want in this case.

Thank you. @eleftherias. I managed fix the lint config on my machine and run the make lint properly. it looks fine locally (no lint errors) in my machine now. However, lint seems to be failing in CI.

[eleftherias]

Thanks for the PR @gajananan!
The code changes look good, there are just a few cleanup items we need before merging this. Could you run make lint on you local machine before committing? This will show the lint errors. Could you change the PR description from Fixes #4380 to Ref #4380? If we have the Fixes keyword then it will close the associated issue, which we don't want in this case.

Thank you. @eleftherias. I managed fix the lint config on my machine and run the make lint properly. it looks fine locally (no lint errors) in my machine now. However, lint seems to be failing in CI.

It could be a mismatched version of the lint tool. Could you try running make bootstrap (to install the required version) and then make lint again?

[gajananan]

Thanks for the PR @gajananan!
The code changes look good, there are just a few cleanup items we need before merging this. Could you run make lint on you local machine before committing? This will show the lint errors. Could you change the PR description from Fixes #4380 to Ref #4380? If we have the Fixes keyword then it will close the associated issue, which we don't want in this case.

Thank you. @eleftherias. I managed fix the lint config on my machine and run the make lint properly. it looks fine locally (no lint errors) in my machine now. However, lint seems to be failing in CI.

It could be a mismatched version of the lint tool. Could you try running make bootstrap (to install the required version) and then make lint again?

Thank you, @eleftherias. I was not aware I was using an old version of lint. It is now fixed.

[eleftherias]

Thanks for your contribution @gajananan!