Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

origination: First get properties from provider before trying to persist #4660

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 7, 2024

Summary

The incoming origination message might not have all properties set. This
finds the entity from the provider before trying to persist.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek
Copy link
Contributor

jhrozek commented Oct 7, 2024

I think the logic is good. Let me fixup the tests as part of reviewing the PR.

The incoming origination message might not have all properties set. This
finds the entity from the provider before trying to persist.

Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
@jhrozek
Copy link
Contributor

jhrozek commented Oct 7, 2024

This works. I updated the tests as part of the review.

@coveralls
Copy link

Coverage Status

coverage: 53.252% (-0.001%) from 53.253%
when pulling 30c6a8a on origination-get-properties
into ba646eb on main.

@JAORMX JAORMX merged commit a531fe5 into main Oct 7, 2024
20 checks passed
@JAORMX JAORMX deleted the origination-get-properties branch October 7, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants