Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output test coverage from unit tests action #4752

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 15, 2024

Summary

This converges the test and the cover actions into one. Having two is
wasteful and the benefit unclear.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This converges the test and the cover actions into one. Having two is
wasteful and the benefit unclear.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11341714732

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 54.024%

Files with Coverage Reduction New Missed Lines %
internal/authz/authz.go 1 69.85%
Totals Coverage Status
Change from base Build 11341699177: 0.6%
Covered Lines: 14800
Relevant Lines: 27395

💛 - Coveralls

@rdimitrov rdimitrov merged commit 932d21d into mindersec:main Oct 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants