Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.20 refactor #238

Merged
merged 51 commits into from
Jan 14, 2024
Merged

1.20 refactor #238

merged 51 commits into from
Jan 14, 2024

Commits on Jan 13, 2024

  1. Rename AbsolutePositions to NonCubeBlockAbsolutePositions

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    df613de View commit details
    Browse the repository at this point in the history

  2. Change block type checking to same style in POIBlocks

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d83ed7b View commit details
    Browse the repository at this point in the history

  3. Add logging for qualified position when checking for fall 

    And remove every-position log
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    78c164f View commit details
    Browse the repository at this point in the history

  4. Remove commented out playSound variable in FallDetector

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    c61df7b View commit details
    Browse the repository at this point in the history

  5. Refactor POIBlocks to use arrays and stream for block predicates

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    5b98c73 View commit details
    Browse the repository at this point in the history

  6. Replace all e.printStackTrace() with proper error log

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    575802d View commit details
    Browse the repository at this point in the history

  7. Add RAY_CAST_DISTANCE constant and extract common logic 

     of getBlockAndFluidTargetInformation and getBlockAndFluidTargetPosition
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    3f6a7f5 View commit details
    Browse the repository at this point in the history

  8. Rename predicate list in POIBlocks

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    1836935 View commit details
    Browse the repository at this point in the history

  9. Move isLockingKeyPressed variable to where it is used first time

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    0ef16de View commit details
    Browse the repository at this point in the history

  10. Remove labeled break, directly return and wait for execution of next … 

    …tick is more simple
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    96c1dec View commit details
    Browse the repository at this point in the history

  11. Simplify the logic of continuous locking after eye of ender disappears

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    aa0b966 View commit details
    Browse the repository at this point in the history

  12. Add description about special logic of POI Entity Locking in manual

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    0f690d2 View commit details
    Browse the repository at this point in the history

  13. Extract player.lookAt as util method 

    maybe we can utilize it in the future, far future when developing new features
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    f78bca6 View commit details
    Browse the repository at this point in the history

  14. Remove isLockedOntoLadder variable, replace it with a simple way

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    334b049 View commit details
    Browse the repository at this point in the history

  15. Correct description about ladder automatically unlocking

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    48e3942 View commit details
    Browse the repository at this point in the history

  16. Extract player look at entity method

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    a083129 View commit details
    Browse the repository at this point in the history

  17. Add BlockPos3d which extends BlockPos 

    so we can use it to save accurate position (Vec3d) and use it as BlockPos type (extended from Vec 3i)
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    6a614dc View commit details
    Browse the repository at this point in the history

  18. Add description about automatic lock release on block destruction or … 

    …change, in manual
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    0815f0f View commit details
    Browse the repository at this point in the history

  19. Rename ClientPlayerEntityProxy to PlayerUtils, and move methods u… 

    …nder original `PlayerUtils` into it
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    2a4ee5b View commit details
    Browse the repository at this point in the history

  20. Move playSoundAtPosition method to PositionUtils

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    65ef4dd View commit details
    Browse the repository at this point in the history

  21. Remove MinecraftClient param on playUnlockingSound method

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    7daaff8 View commit details
    Browse the repository at this point in the history

  22. Extract two special case methods in LockingHandler

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    b13a4a6 View commit details
    Browse the repository at this point in the history

  23. Remove client param from methods

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d24e3f6 View commit details
    Browse the repository at this point in the history

  24. Rearrange locking key press checking logic

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    547c725 View commit details
    Browse the repository at this point in the history

  25. Rename two variables

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    0671daf View commit details
    Browse the repository at this point in the history

  26. Extract unlock method

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    57547f4 View commit details
    Browse the repository at this point in the history

  27. Rename isLockedOntoEyeOfEnderTarget variable

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    214839d View commit details
    Browse the repository at this point in the history

  28. public lockOnEntity method and replace logic in EyeOfEnderEntityMixin

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    164b2fb View commit details
    Browse the repository at this point in the history

  29. Extract entity narration method as util method

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d1dd03b View commit details
    Browse the repository at this point in the history

  30. Move getNarratableNumber method from PositionUtils to NarrationUtils … 

    …and rename it
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    cb152ca View commit details
    Browse the repository at this point in the history

  31. Remove unused imports

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    a00891c View commit details
    Browse the repository at this point in the history

  32. Move getPositionDifference method from PositionUtils to NarrationUtil… 

    …s and rename it
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    a55ddf3 View commit details
    Browse the repository at this point in the history

  33. Move getPosition method from PositionUtils to NarrationUtils and rena… 

    …me it
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d37e0e6 View commit details
    Browse the repository at this point in the history

  34. Move two play sound methods from PositionUtils to WorldUtils and dele… 

    …te PositionUtils
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    c1cc1a4 View commit details
    Browse the repository at this point in the history

  35. Move methods from ClientPlayerEntityUtils to PlayerUtils

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    82081af View commit details
    Browse the repository at this point in the history

  36. Use NarrationUtils for entity narration in LockingHandler

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    ef2c6cc View commit details
    Browse the repository at this point in the history

  37. Extract is player in fluid logic as util method

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d3f34dc View commit details
    Browse the repository at this point in the history

  38. Make methods in PlayerUtils use WorldUtils getClientPlayer() method

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    f5afcf3 View commit details
    Browse the repository at this point in the history

  39. Replace player in fluid check in NarratorMenu with util method

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    0213a3e View commit details
    Browse the repository at this point in the history

  40. Add is alive checking in lockOnEntity method

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    6337609 View commit details
    Browse the repository at this point in the history

  41. Only check locked block entries change

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    8c66fcd View commit details
    Browse the repository at this point in the history

  42. Remove client param on get...AbsolutePosition methods

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    c09e6c4 View commit details
    Browse the repository at this point in the history

  43. Remove client invoking in lockOnBlock method and rename it

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    83714cc View commit details
    Browse the repository at this point in the history

  44. Simplify logic of finding nearest block in scanned blocks

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    071ccb5 View commit details
    Browse the repository at this point in the history

  45. Extract block narration as util method

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    3182a3d View commit details
    Browse the repository at this point in the history

  46. Simplify locked block narration

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    868e6cd View commit details
    Browse the repository at this point in the history

  47. Fix the bug that ignored non-cube blocks locking position

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    a3cff5f View commit details
    Browse the repository at this point in the history

  48. Rename block locking methods 

    to fit logic of lockOnEntity method
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    e1ebce9 View commit details
    Browse the repository at this point in the history

  49. Fix the bug that throws NPE

    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    e83d8bc View commit details
    Browse the repository at this point in the history

  50. Simplify unlock sound playing, make every non-inner-invoking unlock s… 

    …peak "unlock"
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    c2ad423 View commit details
    Browse the repository at this point in the history

  51. Replace config "Play Unlocking Sound" with "Play Sound Instead Of Spe… 

    …ak", let player chose whether to play drum sound or speak when unlocking
    @boholder
    boholder committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    7a5107f View commit details
    Browse the repository at this point in the history