Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pity to card upgrades #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add pity to card upgrades #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/commands/upgrade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ export class UpgradeCommand extends Command {
}

const upgradePrice = condition.upgradePrice * (card.foil ? 2 : 1);
const pityFactor = 0.07 * card.pity;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably not be linear, rather something that slowly approaches but never reaches 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can agree with making it non-linear, though making it "slowly" approach anything seems a bit pointless since most upgrade sequences currently don't even reach 10 total rolls
; this isn't like spending 100 gacha pulls to get your guaranteed SSR character

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? It's pity / (pity + 8)

image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparison with previous formula

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simulated this and got this, it going up steeper early has a stronger effect it seems
but having the average coincidentally hover around the price of a superdrop seems rather neat

Costs
Mean 1501
Median 1300
Std Dev 713

const upgradeChance = Math.min(card.condition.upgradeChance + pityFactor, .8);
const downgradeChance = Math.max(0.5 - pityFactor, 0.3)

const imagePath = await renderCard(card, {cardCode: true})

Expand All @@ -85,8 +88,8 @@ export class UpgradeCommand extends Command {
.setTitle('Upgrade card')
.setThumbnail('attachment://card.png')
.setDescription([
`Upgrading the \`${card.mapper.username}\` card from from **${condition.id}** to **${condition.nextUpgrade.id}** has a ${Math.floor(condition.upgradeChance * 100)}% chance of success.`,
condition.previousUpgrade ? `If the upgrade fails, there is a 50% chance the card will be downgraded to **${condition.previousUpgrade.id}**` : `If the upgrade fails, nothing will happen.`,
`Upgrading the \`${card.mapper.username}\` card from from **${condition.id}** to **${condition.nextUpgrade.id}** has a ${Math.floor(upgradeChance * 100)}% chance of success.`,
condition.previousUpgrade ? `If the upgrade fails, there is a ${Math.floor(downgradeChance * 100)}% chance the card will be downgraded to **${condition.previousUpgrade.id}**` : `If the upgrade fails, nothing will happen.`,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the pity factor should be advertised anywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it displays the odds and the odds change, felt like basic transparency

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still prefer not to give it away, ppl should not really be aware of the pity system

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a fair standpoint, can remove when we've figured it all out

'',
'Attempting to upgrade will cost',
'```diff',
Expand Down Expand Up @@ -176,13 +179,14 @@ export class UpgradeCommand extends Command {
}

const random = Math.random();
const success = random < condition.upgradeChance;
const downgrade = !success && Math.random() < 0.5;
const success = random < upgradeChance;
const downgrade = !success && Math.random() < downgradeChance;
if (success) {
currentCard.condition = condition.nextUpgrade;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure pity should be reset on success

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typical pity systems would do that, but I don't think it would fit here

the main killer in the upgrade system is how much it can fluctuate, in 10% of cases your card downgrades 3+ times by going from good to poor and back on repeat for example
so resetting on success would be a bit pointless since it'd continue to allow those sequences to escalate costs anyway

at that point just reducing overall costs or reducing chance to downgrade in general would be more effective changes, which people would probably also be happy with

} else {
if (condition.previousUpgrade && downgrade) {
currentCard.condition = condition.previousUpgrade;
currentCard.pity++;
}
}

Expand All @@ -208,7 +212,7 @@ export class UpgradeCommand extends Command {
} else {
await response.update({
embeds: [
embed.setFooter({text: 'Upgrade failed' + (downgrade && condition.previousUpgrade ? '. Card is now `' + condition.previousUpgrade.id + '`' : '') ,})
embed.setFooter({text: 'Upgrade failed' + (downgrade && condition.previousUpgrade ? '. Card is now `' + condition.previousUpgrade.id + '`' + '\n' + 'Your chances for future upgrades improved a little..': '') ,})
.setColor('Red')
],
components: []
Expand Down
3 changes: 3 additions & 0 deletions src/entities/card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ export class Card {
@Column('datetime', { name: 'job_mindblocked_until', nullable: true })
jobMindblockedUntil!: Date | null;

@Column('int', { name: 'pity', default: 0, nullable: false })
pity!: number;

@BeforeInsert()
@BeforeUpdate()
calculateBurnValue() {
Expand Down